-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications to allow npm publication and unpkg content delivery. #500
Conversation
…t duplicate package.json in /dist. Apologies for spurious whitespace changes, my IDE chomps trailing spaces on save.
… updated with an Installation section for these additions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is great work @erictheise, thanks!
Thanks @Malvoz, I'm very happy to be contributing to this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @erictheise ! Thanks for your help!
The end result is that the root level of the npm tarball contains
package.json
and the.md
files; these are not carried over into/dist
, which should just contain.js
and.css
files.Apologies for mixing whitespace-only changes in with substantive changes; they're good for consistency but I admit my IDE is aggressive about chomping trailing whitespace.