Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to allow npm publication and unpkg content delivery. #500

Merged
merged 7 commits into from
Jul 30, 2021

Conversation

erictheise
Copy link
Member

The end result is that the root level of the npm tarball contains package.json and the .md files; these are not carried over into /dist, which should just contain .js and .css files.

Apologies for mixing whitespace-only changes in with substantive changes; they're good for consistency but I admit my IDE is aggressive about chomping trailing whitespace.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@Malvoz Malvoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is great work @erictheise, thanks!

@Malvoz Malvoz requested a review from prushforth July 29, 2021 21:40
@erictheise
Copy link
Member Author

Thanks @Malvoz, I'm very happy to be contributing to this project.

Copy link
Member

@prushforth prushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @erictheise ! Thanks for your help!

@prushforth prushforth merged commit 080dc93 into master Jul 30, 2021
@erictheise erictheise deleted the npm-mods branch August 31, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants